[Subject(typeof(HttpClient))]
public class when_making_a_GET_with_stream_response_true
{
Establish context = () =>
{
httpClient = new HttpClient();
};

Because of = () =>
{
httpClient.StreamResponse = true;

httpClient.Get("http://localhost:16000/hello");

};

It should_allow_access_to_response_stream = () =>
{
using (var stream = httpClient.Response.ResponseStream)
{
int count;
int total = 0;
var buffer = new byte[8192];

while ((count = stream.Read(buffer, 0, buffer.Length)) > 0)
{
total += count;
}
total.ShouldBeGreaterThan(0);
}

};

It raw_text_should_be_empty = () =>
{
httpClient.Response.RawText.ShouldBeNull();
};
static HttpClient httpClient;
}

The way you sent the patch I'm not sure would be appropriate. I think this feature is needed but currently it requires a few changes in the way to handle this...

Failing test attached: https://github.com/hhariri/EasyHttp/pull/6

Vimal

epic fail, I should have used ApplicationXWwwFormUrlEncoded content type :) I'm back at the BAD REQUEST's now, but those are my fault also. Sorry for the inconvenience.

No, right now I need to supply an object and a string that sets the content type.

How is the body encoded? Does it no work when using POST now?

I had time to look more in details and I had a wrong assumption that response.StaticBody<IEnumerable<Build>>() should work, it can't work in my case because the JSON returned is not an array, the array is a property on the response.

This is what I need to do to access build on teamcity


class Program
{
static void Main(string[] args)
{
var http = new HttpClient{Request = {Accept = HttpContentTypes.ApplicationJson}};
http.Request.SetBasicAuthentication("laurent", "");
var response = http.Get(
string.Format("http://yourteamcity/httpAuth/app/rest/buildTypes/id:{0}/builds?count={1}", "bt5", 5));

WriteLineUsingStatic(response);
}

private static void WriteLineUsingStatic(HttpResponse response)
{
var r = response.StaticBody<Response>();

foreach (var build in r.Build)
{
Console.WriteLine(build.Status);
}
}

public class Response
{
public ICollection<Build> Build { get; set; }
}

public class Build
{
public string Id { get; set; }
public string Number { get; set; }
public string Status { get; set; }
}
}

What would be better is

private static void WriteLineUsingStatic(HttpResponse response)
{
var builds = response.StaticBody<IEnumerable<Build>>();

foreach (var build in builds)
{
Console.WriteLine(build.Status);
}
}

Saw you were active on twitter so I guessed there were some mail problems :-)

Love that you post as the user "root"

Ah the wonders of non-compliancy :(. Let me think about how we can solve this....

Hadi the current implementation takes advantage of JsonFX decoder localization. Let's chat on IM

Seems this is related to how IDecoder is used. I think IDecoder implementations should be created in the HttpResponse based on the ContentType being Xml or Json. In current implementation there's no way to use both and it is only possible to switch completely to Xml decoders (given there is an implementation of IDecoder) by swapping the whole configuration.

Made some changes...not yet final.

Maybe it would be better to have an ignore serialization attribute? eg. [DoNotSerializeFor(POST)]

Issue with MSpec.

Needs JsonFX package first.

Yep. Was on my list. Will do.